Nathaniel Wesley Filardo

Results 145 comments of Nathaniel Wesley Filardo

Thanks for useful feedback. Here's a revised commit.

CI builds are great, but could you please use a new PR that won't send me email? :)

The correct way to do this, IMHO, is to articulate our build dependencies in the Kconfig language. See #3138 for a stalled effort along these lines.

Sorry, to clarify my position: we should have _one canonical truth_ about our intended dependency relationship, and that source of truth should be in Kconfig; any documentation should be generated...

Ah, I think that's a 5.3 vs 5.1 thing. Let's hold on this PR until @TerryE's done the requisite backporting? Or I could go put the call to `lua_type` back.

When I said "mostly guided by upstream", I meant that most of this was https://www.lua.org/work/diffs-lua-5.3.5-lua-5.3.6.html . The `objbarrier`s are from that, FWIW.

Ah *ha*. After a day of debugging I have finally caught my mistake in this. Of course it was in the `lundump.c` bit where we've diverged from upstream. `LoadFunction` does...

Will merge after #3479 lands.