Nathaniel Wesley Filardo

Results 145 comments of Nathaniel Wesley Filardo

Unclear why CI marked this as failed; Jenkins itself claims "passed but marked unstable".

I just added `CHERITEST_VERIFY` around all the `sig*` calls and, sadly, they all appear to be claiming that the right thing happened in both `cheritest` and `cheriabitest`. Other than that...

https://reviews.freebsd.org/D30863 and https://reviews.freebsd.org/D30864

Oh, yea, that does seem like it's probably wrong, upon re-reading. Backing up, the intent was to use `vm_page_grab_valid` to traverse the existing pages without filling in gaps (with CoW...

Well, FWIW, I just grabbed an amd64 installer for 13.1 and replayed the installations, first placing `/` before `swap` and then again reversing them and the system boots fine... with...

Oh hah. Yes, that seems to work. How's this look?

This is getting a little more broad... I suspect we're going to want to store the parameters as `uintcap_t` (or perhaps `ptraddr_t`) so that it's the same size between hybrid...

This is failing due to the logic at https://github.com/CTSRD-CHERI/cheribsd/blob/4ea9e6bc33debc22355747d79866ef3c92549bb4/sys/vm/vm_map.c#L3037-L3043 After `mprotect(PROT_NONE)`, `entry->max_protection` retains `VM_PROT_READ_CAP|VM_PROT_WRITE_CAP` but `entry->protection` is `0`. The subsequent `mprotect(PROT_READ|PROT_WRITE)` then fails to `VM_PROT_ADD_CAP` because `set_max` is false, so...

Yeah, we're using different `runs-on` for different configurations, so there's no real risk (I think), it just seemed surprising. Thanks for the redesign sketch; I'll ponder such a thing.

> Just referencing an old Illumos / OpenZFS ticket [5532](https://www.illumos.org/issues/5532), which covers similar code lines..but not really sure if its applicable... Looks still applicable to me. Adding a test for...