Kris Nuttycombe

Results 232 issues of Kris Nuttycombe

If you call BlueEyes with a URL such as follows: http://localhost:8080/services/foo/v1/?bar=hi?baz=there The only parameter parsed from the URL will be 'baz'. This should instead be rejected as a malformed request.

This introduces a FeeStrategy abstraction (and `FutureFeeStrategy` for `zfuture`) that can be used to compute fees and required change during the process of transaction build. This also modifies `TransactionBuilder` to...

Instead of always providing this and having it be unused, we could place this behind the feature flag: ```suggestion #[cfg(feature = "transparent-inputs")] pub(super) params: P, ``` _Originally posted by @str4d...

In discussion with @str4d we agreed that this API should for the immediate time being be moved behind the `unstable` feature flag, but we can defer the full removal until...

This adds a feature that provides the ability to encrypt an arbitrary payload such that it may be decrypted by both the recipient of a particular Zcash note and the...

Currently the `Hardened` and `NonHardened` enum constructors are public; this isn't ideal because it allows of constructions of these values that are out of range, and additions using these values...

https://github.com/zcash/librustzcash/blob/main/components/zcash_note_encryption/src/lib.rs#L286-L315 These APIs allow validation to be deferred longer than they need to be, and the callers currently conflate "the transaction had invalid EPK bytes" with "the note is not...

It would be nice to run this test with two different seeds; one that triggers the case where `receivers` contains two different addresses, and one that triggers the case where...

At present it's possible to initialize the accounts table with some number of account/key pairs, but we don't actually have an API to add am account after the initial setup.