Kris Nuttycombe issues

Results 233 issues of


                                            Kris Nuttycombe

Add detailed trace-level logging to `get_spend_info`

`create_account` should raise an error if the caller attempts to create multiple accounts using different seeds.

At present, it would be possible for a wallet implementer to allow the use of multiple seeds in the wallet via `create_account`, which would be a mess. Instead, we should...

zcash_client_backend: Use knowledge of inserted treestates to reduce time to spendability

Goal: to reduce the time to spendability by adjusting how work at the chain tip is prioritized. TODO: summarize in more detail what is now proposed taking into account the...

`zcash_primitives`: Add `orchard` and `sapling` feature flags.

This has been requested by the Brave folks in order to allow them to avoid a dependency on the `sapling-crypto` crate, and we will add a similar flag for `orchard`...

`zcash_client_backend`: Support import of seed phrases from transparent-only wallets.

> More specifically, we realized as part of the discussion that there is probably an existing bug related to the import of seeds from transparent-only wallets, where we are not...

enhancement

zcash_client_sqlite: Recover the original UA when possible in `store_decrypted_tx`

Open an issue for this. _Originally posted by @str4d in https://github.com/zcash/librustzcash/pull/1234#discussion_r1517859140_

zcash_client_sqlite: Make retrieval of the shard position not go through the shard tree.

https://github.com/zcash/librustzcash/blob/main/zcash_client_sqlite/src/wallet.rs#L949-L966 is a bit of a hack; we could get the shard index from the position of the current chain tip, and we don't really need to go through the...

`zcash_client_backend`: Add a `sapling` feature flag that can be switched off to remove the dependency upon `sapling-crypto`.

S-in-progress

Use `ConstantTimeEq` for `UnifiedFullViewingKey` comparisons.

> This should work but is quite ugly. I don't see any reason why keys shouldn't implement `ConstantTimeEq`. _Originally posted by @daira in https://github.com/zcash/librustzcash/pull/1213#discussion_r1509665137_ This will require the implementation of...

zcash_client_backend: Use consistent ordering for type parameters in `scanning` and `wallet` types.

@str4d requested a number of changes similar to the following in #1202; these are being deferred until after #1195 to avoid severe rebase issues. > Minor nit: `vks` is passed...