Kris Nuttycombe

Results 233 issues of Kris Nuttycombe

We need to ensure that merging a patch release tag for one workspace crate to a release branch for another workspace crate that depends on the first cannot accidentally introduce...

This index was not added at the point that the legacy address index column was added so as to avoid having to regenerate the `accounts` table, in favor of deferring...

In order to provide full zcashd wallet replacement capabilities, `zallet` needs to be able to function as a fully-transparent wallet. This includes the creation of transparent change.

At present, when performing out-of-order scanning, finding a note results in a `FoundNote` priority range being inserted into the scan queue. This priority range likely has a different size than...

> In the case that this upsert is triggered by a note that was received in a pool that the conflicting row's address does not contain, we should upgrade the...

In https://github.com/zcash/librustzcash/blob/main/zcash_client_sqlite/src/lib.rs#L1175, we set and use a fixed power-of-two chunk size for note commitment tree subtree construction. A minor performance improvement would be to use the power-of-two boundaries in the...

> I'm a little unhappy about the lack of Revision 1 tests. I think we'll be fine for now (particularly if my earlier suggestion to generate arbitrary revisions for proptests...

It should be possible to entirely delete data associated with a single account.

At present, zcash-inspect isn't terribly easy to use because you have to manually provide transparent input information in an undocumented format. It would be simple enough to add an option...

An approach to fixing this would be to construct an input source that only selects the note(s) with a given nullifier. Then the caller could specify "I only want to...