Nick Schonning

Results 645 comments of Nick Schonning

The original commit was mostly done by another PR, but adding the node plugin started to lint the MJS files, that I guess were skipped right now

Trying another rebase/bump

Interesting, got an error when setting the compat to >=12 `The 'fs.rmSync' is not supported until Node.js 14.14.0. The configured version range is '>=12'` in create-example-tests.js

The ignore files probably need to be updated for the new paths to continue to be ignored for some of the vendored files: - https://github.com/w3c/aria-practices/blob/main/.eslintignore - https://github.com/w3c/aria-practices/blob/main/.stylelintignore - https://github.com/w3c/aria-practices/blob/6aaf4d48fc690a9d5ddbfbec32cfc7f15a16dd40/cspell.json#L264

@jeffwilcox did you want me to try and fix up the conflicts or just close it?

@jeffwilcox I rebased out the changes from `npm run fix` (and possibly some manual cleanups). Backed that up to https://github.com/nschonni/opensource-portal/tree/eslint-prettier-old branch in case there was anything useful in the manual...

Just added the call back to linting in the CI in a separate commit, so that the current issues will get shown with the setup-node problem matcher ![image](https://user-images.githubusercontent.com/1297909/136475264-ea1493e6-fd62-43d1-97d7-2694096270a5.png)

I opened up https://github.com/microsoft/opensource-portal/pull/199 just as a "line in the sand" without impacting the refactoring

Demo run is https://github.com/nschonni/cz-conventional-changelog/runs/4403067285?check_suite_focus=true but is currently failing on all platforms. ``` 1) commitlint config header-max-length with no environment or commitizen config override: TypeError: explore is not a function at...

Seems like https://github.com/commitizen/cz-conventional-changelog/blob/6446be374ecde802cbfa8a99974493fae16b7dce/package.json#L43 needs to be pinned to just `^6.1.1` since newer versions have a few different breaks depending on which newer one NPM decides to peer install.