Nick Schonning

Results 465 comments of Nick Schonning

Makes sense to me. I think that if the preview is successful, it could also remove the label. The instructions in https://github.com/nodejs/nodejs.dev/blame/695b54d12f249028b6120a2e7734fa6729e1e6b9/.github/PULL_REQUEST_TEMPLATE.md#L18 will also need to update if this is...

Took a try with https://github.com/nodejs/nodejs.dev/pull/851

Potentially, the label could be added to PULL_REQUEST_TEMPLATE frontmatter if a preview is wanted on all PRs

The label system is active, but the old workflow hasn't been retired

@MylesBorins looks like this might be the one that would be supported for the current setup https://github.com/google-github-actions/setup-gcloud#service-account-key-json. I guess it would be combining the two existing keys into a JSON...

I'm also not sure if this is really a feature that will land. Today these files aren't in the nodejs.org repo, as you're taking about a lot of files per...

@tabatkins not sure why this got stuck, but maybe closing it and letting it recreate itself will get it unblocked

Since the syntax highlighting comes from https://pygments.org/, that part probably needs a request there for that part

Possibly coming from https://github.com/html5lib/html5lib-python upstream

Aside, might be worth adding the repo to https://github.com/tabatkins/bikeshed/blob/main/.github/workflows/update-tests/specs.data