cz-conventional-changelog icon indicating copy to clipboard operation
cz-conventional-changelog copied to clipboard

chore: convert Travis to GitHub Actions

Open nschonni opened this issue 4 years ago • 3 comments

The publish could probably be replaced with https://github.com/cycjimmy/semantic-release-action, but would require the GitHub secrets to be configures so I skipped it for now. Mostly copied over from https://github.com/htmlhint/HTMLHint, where the semantic release part is used

nschonni avatar Dec 03 '21 01:12 nschonni

Demo run is https://github.com/nschonni/cz-conventional-changelog/runs/4403067285?check_suite_focus=true but is currently failing on all platforms.

  1) commitlint config header-max-length
       with no environment or commitizen config override:
     TypeError: explore is not a function
      at Z:\cz-conventional-changelog\node_modules\@commitlint\load\lib\index.js:158:26
      at new Promise (<anonymous>)
      at loadConfig (node_modules\@commitlint\load\lib\index.js:152:9)
      at Object.<anonymous> (node_modules\@commitlint\load\lib\index.js:44:25)
      at new Promise (<anonymous>)
      at exports.default (node_modules\@commitlint\load\lib\index.js:42:68)
      at mockOptions (engine.test.js:431:41)
      at Context.<anonymous> (engine.test.js:448:14)
      at processImmediate (node:internal/timers:464:21)

nschonni avatar Dec 03 '21 01:12 nschonni

Seems like https://github.com/commitizen/cz-conventional-changelog/blob/6446be374ecde802cbfa8a99974493fae16b7dce/package.json#L43 needs to be pinned to just ^6.1.1 since newer versions have a few different breaks depending on which newer one NPM decides to peer install.

nschonni avatar Dec 03 '21 01:12 nschonni

With 9+, the error becomes

  1) commitlint config header-max-length
       with no environment or commitizen config override:

      AssertionError: expected { Object (types, defaultType, ...) } to have property 'maxHeaderWidth' of 72, but got 100
      + expected - actual

      -100
      +72

      at Z:\cz-conventional-changelog\engine.test.js:449:33
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

nschonni avatar Dec 03 '21 01:12 nschonni