aria-at icon indicating copy to clipboard operation
aria-at copied to clipboard

chore: Add ESLint Plugins

Open nschonni opened this issue 5 years ago • 9 comments

Preview Tests

Causes a big diff now, but has the same setup as aria-practices, so should make the syncing in #339 easier

nschonni avatar Nov 20 '20 23:11 nschonni

@howard-e before I try and rebase this one, is this something you folks are already working on?

nschonni avatar Feb 17 '22 15:02 nschonni

@howard-e before I try and rebase this one, is this something you folks are already working on?

You can go ahead @nschonni!

howard-e avatar Feb 17 '22 15:02 howard-e

The original commit was mostly done by another PR, but adding the node plugin started to lint the MJS files, that I guess were skipped right now

nschonni avatar Feb 17 '22 21:02 nschonni

Deploy Preview for aria-at failed.

Name Link
Latest commit 2cf008327d85a25b22944e13f09013b97f513bd9
Latest deploy log https://app.netlify.com/sites/aria-at/deploys/624343551f0d100008b78c5d

netlify[bot] avatar Mar 15 '22 19:03 netlify[bot]

Not sure why that's failing for you @nschonni. Taking a look.

howard-e avatar Mar 15 '22 19:03 howard-e

Ahh, seems some code updates are missing.

howard-e avatar Mar 15 '22 19:03 howard-e

Trying another rebase/bump

nschonni avatar Mar 15 '22 20:03 nschonni

Interesting, got an error when setting the compat to >=12 The 'fs.rmSync' is not supported until Node.js 14.14.0. The configured version range is '>=12' in create-example-tests.js

nschonni avatar Mar 29 '22 17:03 nschonni

Interesting, got an error when setting the compat to >=12 The 'fs.rmSync' is not supported until Node.js 14.14.0. The configured version range is '>=12' in create-example-tests.js

Good catch. Since this project already makes use of rimraf, that line could be safely replaced with rimraf.sync(path.join(sourceFolder, file));

howard-e avatar Mar 29 '22 18:03 howard-e