Steve Myers
Steve Myers
I'd prefer to merge this as is rather than doing any more renaming at this point.
@ValuedMammal this looks good but could you add a simple test as above but also that hits this new `None` case?
> I added to the existing `feerate_parsing` test which tests the logic in `convert_fee_rate`. I'm not sure if you're suggesting to add another test? @notmandatory @oleonardolima Oh sorry I didn't...
Since this one is still having design discussions can I move it out of the 1.1 milestone?
Took this out of the `bdk_wallet` 1.1 milestone since tagging the release tomorrow.
I haven't done a deep review but I support merging this now that we're done with the `bdk_wallet` 2.1 release.
Since this doesn't touch the wallet APIs I moved it to the beta milestone.
@LagginTimes oops, I didn't read all the comments before, looks like the wallet API will need to be updated so I've moved this back to the alpha milestone.
@LagginTimes hey sorry I just merged some smaller PRs and now this one needs a rebase.
Based on above benchmark results it looks like this change is 1s faster on sync, is that due to a small test size? Do we expect it to make more...