Steve Myers

Results 580 comments of Steve Myers

@tnull good call. I took it off the list.

Moving this to the 3.0 milestone when I hope we'll be able to bump to a higher MSRV which will make these updates easier.

Maybe rather than caching the bitcoind and electrsd binaries we can create a docker image with them and setup in the runner's env. Or use the nix dev shells from...

@nymius I've assigned this to you, thanks for jumping in to take this on.

Can we push this TLV work for the `bdk_file_store` out of the 1.0.0-alpha milestone? This would let the team focus on #1496 and #1498 changes and we'd only deliver backward...

I discussed this with @evanlinjin and decided this issue can be moved to the 1.0.0-beta milestone. We just need to warn beta users that if they want backward data file...

My 2 sats on this is that file store is 1. a good as a simple example, 2. only really needs to show backward compatibility (not forward), and 3. isn't...

For the audit issue bitcoindevkit/bdk#1698 you fixed it with bitcoindevkit/bdk#1756. Can you update this to just be checking Merkle proofs? And if so then I'd say this is a new...

I moved the state of this PR back to "In Progress" and took it out of the 1.1 release since https://github.com/bitcoindevkit/bdk/pull/1792#pullrequestreview-2541613102 still needs to be addressed.

Since we've moved `bdk_wallet` into it's own repo (#1928) you'll need to remove the `bdk_wallet` change from this PR and put it in it's own PR in the new `bdk_wallet`...