Steve Myers
Steve Myers
I fixed the tests, I don't think they look too bad with the non-exhaustive change sets.
Ah ok I completely forgot we discussed this last year. It seems we have conflicting goals: * I want to be able to add new, default-able fields in persisted data...
~~Am I correct in understanding that this change would allow you to remove `LocalChain` from bdk_kyoto and just directly query and update the wallet's chain?~~ Nevermind above, but I am...
I like @ValuedMammal 's suggestion since it clearer when/why you'd use this function. The new wallet test would then look like below. One nit, could we call this function `disconnect_checkpoint()`...
@stevenroose The config in this file is consistent with default rust-fmt right? Also need a rebase to pickup recent ci change then this should be good to go in.
@BinChengZhao it looks like the proposed rust-bitcoin/rust-bitcoin#2945 is a breaking change and we're not planning to change our `rust-bitcoin` minor version for the bdk 1.0 milestone. But even with current...
I think we won't be able to fix this issue until rust-bitcoin/rust-miniscript#681 is done.
This could be solved by providing documentation and examples as described in bitcoindevkit/bdk_wallet#140 .
@darioAnongba please take a look and let us know if this is OK and also ping me when the new bitcoin feature is live so I can publish the page....
@sdmg15 yes these are the current owners, but since you're a new contributor I don't recommend this as your first issue. See: https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md#first-time-contributors