bdk icon indicating copy to clipboard operation
bdk copied to clipboard

Add CI tests for building individual packages

Open notmandatory opened this issue 2 years ago • 5 comments

Describe the enhancement

As described in bitcoindevkit/bdk#1017 it's possible in the build-test job for --no-default-features and --all-features tests to pass, but building individual packages can still fail.

To make sure this doesn't happen again we should test building each package individually with default, --all-features, and --no-default-features.

Use case

Catch broken feature configurations sooner.

notmandatory avatar Jun 26 '23 02:06 notmandatory

I gave it a try, and it doesn't seem each package can be built with --no-default-features, at least is not the case for bdk_wallet because of miniscript std/no-std requirement, see https://github.com/bitcoindevkit/bdk/actions/runs/10565729093/job/29270897594?pr=1575

oleonardolima avatar Aug 26 '24 19:08 oleonardolima

Oh, I guess that's the reason we have the check-no-std job :think:

oleonardolima avatar Aug 26 '24 19:08 oleonardolima

I think we won't be able to fix this issue until rust-bitcoin/rust-miniscript#681 is done.

notmandatory avatar Sep 05 '24 16:09 notmandatory

I'll check if the changes from miniscript#681 would unblock this.

oleonardolima avatar Nov 13 '24 17:11 oleonardolima

@notmandatory I think this should be moved back to bitcoindevkit/bdk, as this repository only contains bdk_wallet.

oleonardolima avatar Apr 16 '25 18:04 oleonardolima