Steve Myers
Steve Myers
The latest and greatest rust-hwi is published and ready to go: https://crates.io/crates/hwi
I did some digging into the broken test and found I could fix it by removing the line in `Wallet::create_tx()` where we always add the fee for 2 WU when...
> @notmandatory you mean the bug was hiding in the line of code with **9 lines of comments** describing why it was there, I probably could have looked a bit...
Rather than try to figure out how to get this to build with MSRV 1.57 I'm bumping it to 1.63.0. ~~For some reason CI isn't running at all so I...
~~@thunderbiscuit I think you are right now that I'm looking at the code again it looks like coin selection WILL add more inputs to pay the fee so will drain...
I updated the test to confirm that given a wallet with 2 UTXOs, if the original TX only uses one UTXO then the new fee bumped TX with `allow_shrinking()` will...
How about we just deprecate `allow_shrinking()` in this release (and in corresponding bdk-ffi API) in case anyone is using it, and then remove it completely in the next release (and...
~~I'll take a crack at implementing your new `KeychainTxOutIndex` design, but if @danielabrozzoni gets to it first in this PR that's fine too. At least I'll be a better reviewer...
Please rebase now that #1183 has been merged.
I fixed some new CI issues with #1247, it just needs to be ACKd and merged and then this PR rebased.