Steve Myers comments

Results 580 comments of


                                            Steve Myers

Inconsistent checking of RBF rules

More notes from @evanlinjin from discord chat: "We already have the TxParams::bumping_fee field we just aren't checking them correctly. However, I am concerned about rule 4 not being enforced properly...

Inconsistent checking of RBF rules

Thanks @LLFourn , if you can fix with integration of `bdk_coin_select` that'd be great.

Inconsistent checking of RBF rules

@LLFourn Since we're not going to have have a `bdk_coin_select` crate for 1.0 can I defer this issue to the 2.0 milestone?

Inconsistent checking of RBF rules

Yes I'd like to make the extracted `bdk_coin_select` one of the priorities for 2.0 so if it's better to fix this together with that I'll update the milestone.

Migrate from structopt to clap.

I updated the branch protection rules to check for the tests run against 1.57 instead of 1.56. Looks like you just need to fix up the WASM.

Test to showcase high memory consumption of `batch_script_get_history`

Thanks for test to repro this issue, any ideas why it might be happening? And do you think this would be a common usecase? In most cases I'd expect this...

Test timeout

This is pretty old, is it still something we need and should I target this for the next release?

WIP: Implement balance-fetching for derivable descriptors

Hi, this is pretty old and I'm not sure this sort of functionality belongs in the electrum client. But if you still think it's a good idea and want to...

WIP: Implement balance-fetching for derivable descriptors

Closing for now. If someone wants to pick it back up we can reopen.

Error using BIP21 URI with BOLT 11 invoice

Thanks, yes I can confirm this is a duplicate of #321 and the same work around worked for me.