Steve Myers

Results 580 comments of Steve Myers

I agree we should use rust-bitcoin `BlockHeight` and that for `UnixSeconds` it might be better to wrap the u64, unless it's already done somewhere in the core lib (for no-std...

@15IITian which `Time` struct do you mean? The closest equivalent to what I think we need in BDK is [`block::Header.time`](https://docs.rs/bitcoin/latest/bitcoin/blockdata/block/struct.Header.html#structfield.time) which is a `u32`. But even that isn't exactly what...

For building transactions with a `locktime` I completely agree we should continue to use the `rust-bitcoin` `absolute::LockTime` enum which uses the `absolute::Time(u32)` struct. The `UnixSeconds()` struct I have in mind...

To put the current proposal into nuts and bolts, in `chain_data` and code that calls it, change: * `u64` used for **confirmed** block or transaction time to rust-bitcoin `locktime::absolute::Time` *...

I put this on the project board, I think we should do it after #1203 and #1101 are merged. But should grab the `bdk_wallet` account in crates.io ASAP.

> hey @notmandatory. What do you think about the approach of just putting the the data in actual tables rather than serializing it in some blob? It's funny you should...

FYI I rebased off of #1203 so only look at my commits.

I've implemented the `PersistBackend` trait for SQLite with the below change set type. Next step is to test it out with the examples. ```rust #[derive(Clone, Debug, PartialEq)] struct ChangeSet +...

I've rebased this PR on the latest version of #1203 and everything seems to be working fine in the new `sqlite_store` crate. There are still some build errors in other...