Steve Myers
Steve Myers
I found this site useful for figuring out how to shrink release binaries: https://github.com/johnthagen/min-sized-rust
I propose we push to to a post 1.0 release since it's a functional improvement that shouldn't change the current wallet API.
Ya I did remove this `debug_assert!` in #1194 but if someone wants to remove it sooner in another PR that's fine by me.
A small change but I think we should push to 2.0 milestone.
Yes I like that idea, and between 1.0 and 2.0 we can slowly deprecate old naming and add the new ones. We just can't fully remove the old names until...
We only need to change `Wallet::get_balance()` to `Wallet::balance()` so we should be able to get this in to the 1.0 milestone. The `Wallet::get_address` fix was done in #1402. Any other...
Thanks for the headsup and trial patch. Any rough ETA for 0.31 ? Since this would be a breaking change we need to figure out if it could make it...
@tcharding I see that rust-miniscript 11.0 was released with rust-bitcoin/rust-miniscript#618, if the changes aren't too big can we get this into our 1.0-alpha.4 milestone?
I'm moving this to up to the 1.0.0-alpha.4 release since rust-bitcoin 0.31.0 and rust-miniscript 11.0.0 are released. @tcharding has also created PRs to upgrade the other crates we depend on,...
> Looks like `hwi` is the final missing piece. The `bitcoin` upgrade is done there already. Thanks! didn't have `hwi` on my list but will work on getting it ready...