Lee ByeongJun
Lee ByeongJun
I think I had a pretty narrow view. I didn't think of that. Thank you for your criticism
@fanninpm Thanks for your advice! It's definitely better than before 👍👍
@youknowone I don't know if this is right way, but I removed `@unittest.expectedFailure` from the `test.test_format.FormatTest`.
Memo: Once this PR is merged, I plan to implement the cursor movement and history save/load features proposed in issue #1416. Additionally, to achieve more sophisticated indentation control, I intend...
> Thanks for the updates. It looks a lot better 👍 . Please see the comments I left. A few things seem to be broken and a couple others unnecessary....
> What about using ast/parser then ast/format? That would be practical. I'll ping you after update current code. 👍
> Have you considered porting over [buger/jsonparser](https://github.com/buger/jsonparser)? It is an existing reflection-free JSON implementation. Yes, I'm currently working with jsonparser as a reference.
It's not finished yet, but I've updated the status for an interim check.
> Maybe consider adding `unicode/utf16` to the whitelist Oh... I didn't realize this existed, added it. thank you @harry-hov !
Now that I think about it, `unicode/utf16` should be PR'd separately. it's not being used in JSON so it seems unnecessary to do it together.