Lee ByeongJun comments

Results 79 comments of


                                            Lee ByeongJun

feat(p/json): JSON path support

> Hello @notJoon . Some CI tests from Sept. 3 failed. Maybe merge master again to see if they pass? It causes an unknown panic, so I'll leave it in...

feat(ufmt): enhance printf functionnalities by adding flags

@paulogarithm Hmm... When using `ufmt` (especially, using `Sprintf` function), gas consumption increases causing "out of gas" errors and test failures. The other CI failure issues will likely be resolved with...

feat(ufmt): enhance printf functionnalities by adding flags

> can you try putting the maps in the scope like i did, even if it's more greedy on memory ? I'm testing by directly checking the gas consumption with...

feat(ufmt): enhance printf functionnalities by adding flags

@paulogarithm I couldn't push directly to this PR #4174, so I created a separate PR. Please check it and feel free to cherry-pick if needed. thank you 👍

fix(gnovm): forbid start expression when value is not a pointer

It looks fine to me. However, I found that for the following case, the error message slightly differs from what Go outputs: ```go package main const VALUE = 5 func...

fix(gnovm): forbid start expression when value is not a pointer

> > It looks fine to me. However, I found that for the following case, the error message slightly differs from what Go outputs: > > ```go > > package...

fix(tm2): Enable coin benchmark tests after fixing panic error

Could you please provide more detailed context for this PR's changes? thank you

feat(p/json): optimize json

> Hi @notJoon. Maybe it's obvious to people familiar with the code, but in the description can you put a short explanation why you removed the eisel_lemire and ryu folders?...

feat: GC

Everything looks good to me. I just added a simple suggestion just to increase test coverage 👍

feat(gnovm): Test Coverage Support

For simplicity for reviewing I'll change this PR as ready for review.