Nicolás Ojeda Bär comments

Results 510 comments of


                                            Nicolás Ojeda Bär

dune format-dune-file: use Dune lang version of current Dune project

I think all issues raised so far have been addressed, so the PR could be merged in principle. @rgrinberg: what do you think?

dune format-dune-file: use Dune lang version of current Dune project

Thanks @Alizter!

Draft: Add Merlin's Typing recovery

I haven't looked at the code, but am strongly in favour of this. For future reference, can you briefly mention what other components are keeping Merlin from being an ordinary...

FUNCTION: document inclusion of module-level let-bindings

Thanks for the suggestions! What about: ``` (** [__FUNCTION__] returns a period-separated string consisting of the names of all enclosing functions, methods, classes, modules, and top-level let-bindings. ```

FUNCTION: document inclusion of module-level let-bindings

> Technically methods are separated from their class by a `#` symbol, not a period. I'm not sure how important it is to mention it. Good point. We could avoid...

FUNCTION: document inclusion of module-level let-bindings

We could go for maximum precision, but this will make it harder to change the format in the future: `__FUNCTION__` returns a string of the form `"N0n1n2..."` where `N0` is...

FUNCTION: document inclusion of module-level let-bindings

@lthls @gasche are you satisfied with the latest formulation?

FUNCTION: document inclusion of module-level let-bindings

> I would say explicitly that it is best-effort and may change later. Seems fair, I will add a note about this.

FUNCTION: document inclusion of module-level let-bindings

I pushed cf28a4545b829de893f75714fa7f3bf3c6c3e9c9 with the latest changes. This is what it looks like in rendered form:

Add {Set,Map}.S.get_singleton

Sorry I had missed the point about naming raised by @dbuenzli. Feel free to consider my approval as "approval-modulo-naming".