Nicolás Ojeda Bär
Nicolás Ojeda Bär
(Thanks for including a detailed benchmark, by the way!)
> For the record, the proposed function has the following signature: Ah, it is not the same as `List.concat_map`; I should have looked more carefully. Thanks for the correcting me.
Friendly ping @damiendoligez.
I added a warning when using `dune format-dune-file` inside Dune, as this may not give the expected results (root detection behaves differently in that case) and the `(format-dune-file)` action seems...
> Tests are failing in this one Thanks, coming back to this PR after the holidays. The test error was due to `INSIDE_DUNE` being set in the tests so that...
> Thank you @nojb for this work. I wanted to note I'll be a happy a user of this as I have started some work for fixing [mbarbin/dunolint#88](https://github.com/mbarbin/dunolint/issues/88) but it...
> I report that this PR fixes the formatting issue encountered with dune.3.20 when [using dunolint as an Emacs reformatter](https://mbarbin.github.io/dunolint/docs/guides/reformatter/). Thanks for the confirmation! I haven't had time to look...
> Is the fact that a log is created a behavior change of 3.20, or perhaps an artifact of building in dev mode? To be clear, I don't mind the...
> If I try to build your PR in release mode, I get this: `make release` is pretty finicky regarding dependencies. I normally use `make dev` for testing. In any...
> Besides the technical consideration of making it work today, I guess I am also trying to do some due diligence that my use case aligns with your longer term...