Nicolás Ojeda Bär

Results 260 comments of Nicolás Ojeda Bär

As far as I understand from the discussion in #48, the implementation there is viable and could be used as a basis for further work. I can rebase that PR...

Hi, thanks for the reply. But doesn't what you say contradict the spec: > The setext heading underline cannot be a lazy continuation line in a list item or block...

Thanks people, I understand now 😄

Hiya, just FYI I am beginning to try this on Windows. I managed to build the library with the `mingw64` compiler and the `libuv` backend (not completely trivial due to...

BTW what do you use for testing? The files in `test/`?

> Yes. `dune runtest` should run all the tests. Unfortunately they rely on `mdx` and its status on Windows is not very clear (see realworldocaml/mdx#295). I will try to run...

Root cause seems to stem from `ocaml-re`, see https://github.com/ocaml/ocaml-re/pull/197

> It looks like your fix is included in ocaml-re 1.10.0 https://github.com/ocaml/ocaml-re/releases/tag/1.10.0 if you confirm it's fixed we can add the `re >= 1.10.0` dependency to ocamlformat Thanks for the...

> ocamlformat now requires `ocaml-re.1.10.3` (#2133), are there still some Windows-specific things to fix or can we close this issue? Hi. Sorry, this had dropped out of my radar. Yes,...