Nicolás Ojeda Bär
Nicolás Ojeda Bär
What is the status of this PR? It seems to be dependency of a number of other PRs #13348 (and transitively, #13360 #13355 etc).
> We're never short of eyes, so, @nojb if you've heard of a Windows or pthread expert around here these days, maybe they could have a look at it? I...
> @nojb, you have not expressed an opinion on this PR. Do you think that this approach is reasonable? The approach is certainly reasonable. This PR is replacing the Windows-only...
Sounds like a good idea. @kit-ty-kate: would you be willing to prepare a PR? Thanks!
OK, thanks!
Friendly ping @kit-ty-kate (just so that we do not forget about this issue).
I'm not sure about this one. `char`s do not represent characters, but bytes (integers in the range 0-255) and they are compared as integers. Suggesting otherwise risks confusion more than...
> Since `char`s can be written literally, like > > ```ocaml > let () = assert('Z' < 'a') > ``` > > maybe this is useful? Maybe we could phrase...
@Villetaneuse sorry for the lag getting back to you on this. We discussed this change during the last triage meeting and we thought it would be better to document this...
I don't remember if the two approval rule applies also to documentation PRs. In any case, an additional official review would be appreciated. cc @gasche @Octachron @dra27