Nicolás Ojeda Bär
Nicolás Ojeda Bär
> It'd be slightly better to have an example of syntax for each new local structure item, perhaps in testsuite/tests/exotic-syntax. Probably not strictly necessary, but it'd help make sure there's...
> > I suppose it's been discussed in past PRs, but I haven't seen such discussions, so feel free to ignore this: to me, the name Pexp_letitem seems more consistent...
> Should they be updated too, or are classes obscure enough to leave them untouched? I wouldn't say that, but `let` bindings in class expressions have enough peculiarities (see eg...
> Just added `Scanf.lscanf`, which can be used as such: Not been following the discussion in detail, but my feeling is that it may be better to only expose an...
> OCaml doesn't seem able to quote files with line directives. [`Location.is_quotable`](https://github.com/ocaml/ocaml/blob/f252da5314f3eda4967da5caf6eafedcdcabef2c/parsing/location.ml#L713) returns `false` for a file that starts with e.g. `# 1 original.ml`. I believe this is expected: the...
We discussed this during the triage meeting and the consensus was that trying to recover the contents of files other than the current input is not very easy. So PRs...
> The rest is an attempt at having almost identical code between shared functions in the runtime and in libunix. I think this makes sense.
I took the liberty of rebasing on the latest `trunk` and am planning to merge once CI passes. Thanks!
> What's the use-case for FLEXLINKFLAGS? FWIW, I know of a commecial user of OCaml on Windows which uses `FLEXLINKFLAGS` to link a resource file (`.res`) to all generated artifacts,...
> Ah, I worded it poorly - I meant using it this way while building OCaml itself, rather than whether the feature in flexlink was used (or is that also...