Nicolás Ojeda Bär

Results 510 comments of Nicolás Ojeda Bär

> It would be good to give an intuition of why this is needed (if a GC is triggered then values can move and pointers need updating). Then explain that...

I made an attempt at clarifying the documentation over at https://github.com/ocaml/ocaml/pull/14273.

Can we consider this issue to be resolved following the merge of #14273?

> As I said, we want to use the **sources**. Notice that you'll still need to enable a more recent menhir at some point. Absent a patch for Merlin itself...

Hello @maxRN; thanks for trying to contribute a patch for this issue. I suggest you open a PR when you feel ready so that your patch can be reviewed by...

> I suggest you open a PR when you feel ready I had missed you had already opened the PR, sorry about that.

> If I change the way `dune fmt` formats something, would that change need to be versioned I think so; people do not generally like having diffs appear after simply...

> This may not look as nice as what's done in the linked PR, but perhaps this is simpler. Just a thought! Personally, I think this is a good idea;...

> Implementation wise it might not even be simpler, because now instead of a string like `\> Some text` we now have a string like `Some text\n\` and in both...

This is an upstream version of an already merged PR over at https://github.com/ocaml-flambda/flambda-backend/pull/4042.