Nicolás Ojeda Bär
Nicolás Ojeda Bär
> ping @nojb any more suggestions for the name? I'm afraid that actually I haven't had time to look at this PR in detail so I don't understand what it...
> Another friendly ping @nojb Sorry for the lag. I read the issue description again but I'm afraid I still do not understand what this PR is about. You mention...
> Sure, I can clarify: > > 1. We rename our vendored library `re` to `dune_re` > 2. Add `(auto_open dune_re)` to the exported list of flags > 3. Write...
> > eg one could use it to "auto-open" arbitrary modules > > I imagined this capability would be useful to people. For example, i might not want to open...
Another issue I can see: if more than one library uses `(auto_open)` there is no clear way to choose an ordering for the `-open` flags. Taking a step back: is...
> So the way I see it, this feature is the absolute minimum that is required to solve the problem at hand and is easy to understand (even if the...
> Is it the case that the `Jstr.t` in these functoins encode one byte per UTF-16 unit? Answering to myself: yes, looks like it is the case: https://github.com/dbuenzli/brr/blob/25f991e9021c0c5a306e2605dd1148fb3334f499/src/brr.ml#L734-L745 I suspect...
Thanks @Armael for the note! Indeed it looks like a similar issue, so perhaps it would be a good idea after all to use `gcc -r` instead of `ld -r`...
> Here it is, I think: Thanks @Armael for the example, which I could reproduce as well. I confirm that using `gcc -r` instead of `ld -r` fixes it: https://github.com/ocaml/ocaml/pull/13202/commits/3831b81278cdece281e12bbe573e1cddfd410f3f.