Nicolás Ojeda Bär

(This is useful for terminal UIs such as text fields, etc.)

> What address can I send a patch to? Microsoft GitHub will let you attach all sorts of stuff like Microsoft Word Document files to comments, but not a useful...

> @rgrinberg and I are planning to upstream our internal changes to the engine in November. That's good to hear! > I would very much prefer reviewing a patch on...

> notably, by checking whether an expected type is principally known. I gave it a try, but could not figure out how to do it (I am not sure what...

Thanks for the pointers @goldfirere! > just use `is_principal` (from `Ctype`). For future reference, this is apparently referencing the following function of the JS fork: https://github.com/ocaml-flambda/flambda-backend/blob/bca81e9f87b7833089d16bbfd694fc8be36dacf5/ocaml/typing/ctype.mli#L631-L633 which I cherry-picked to...

> `is_principal` is available in trunk, but it is in Typecore. You can move it to Ctype as in the JS fork, but then you should remove the one in...

> modulo some suggestions I've made here. Thanks for the review @goldfirere! I will tweak the patch as suggested shortly. > But do we want this patch? I'm not the...

> I've proposed an implementation here: [nojb#13](https://github.com/nojb/ocaml/pull/13) This is now merged into the PR. Thanks again!

> So I believe the order of the checks should be inverted: Thanks for the review @garrigue! I committed your suggestion in https://github.com/ocaml/ocaml/pull/13340/commits/ce706fbab2e7484892424554925b37dce0c2ff93 (the effect can be seen in the...

Thanks @gasche for working to achieve consensus around this feature! > I think it would be nice if you could add some documentation for the PR, either in the user...