nnop

About the viewpoint of turntable camera

3

I'm confused by the viewpoint of the turntable camera. My test code (vispy 0.9.4): ```python canvas = scene.SceneCanvas(keys='interactive', show=True) view = canvas.central_widget.add_view() axis = scene.visuals.XYZAxis(parent=view.scene) view.camera = 'turntable' camera =...

How much would the hook wrapping affect the execution time?

3

Say my application is a concurrent application and the hook implementation is applied to a great amount of data, which means it would be executed thousands of times. So, how...

RTS smoother implementation bug?

1

RTS implementation only use posterior outputs of Kalman filter. https://github.com/rlabbe/filterpy/blob/06bd64fbb50b70e8bfc2be180c8e0a2fedd087f0/filterpy/kalman/tests/test_rts.py#L43-L46 However, according to [wikipedia](https://en.wikipedia.org/wiki/Kalman_filter#Rauch%E2%80%93Tung%E2%80%93Striebel), both posterior and prior of **x** and **P** should be used. >  This seems a...

Wrong implementation of median frequency re-weighting.

2

https://github.com/kwotsin/TensorFlow-ENet/blob/8bb8322b343f65fa8740f731d31fcb361d8546f7/get_class_weights.py#L88-L94 The implementation is not consistent with that stated in (Eigen and Fergus, 2015) :  Reference: - D. Eigen and R. Fergus, “Predicting depth, surface normals and semantic labels...

Feedback on similarity

1

In reference to version 224734d7be7ff0c4a8adb3a206356ea122112f33 Shouldn't D(x e_1 + y e_2) = 2x e_1 `+` 1/2y e_2?

What's the meaning of variable name`str`? Why choose a name could be easily confused with string as convention. https://github.com/aferral/Structure-from-motion-python/blob/374e2d13e0372ece081cfcd2e96a47664bfb3962/utils/graph.py#L60

The `render_3d()` method has an `rot=False` argument. https://github.com/brjathu/T3DP/blob/de6aeb603aedf59c1da587f3f60b8c4ead0a4f8a/models/hmar.py#L107 It seems the argument prohibit the `verts` from being translated to world frame: https://github.com/brjathu/T3DP/blob/de6aeb603aedf59c1da587f3f60b8c4ead0a4f8a/models/hmar.py#L141-L151 Is that right?

get_affine_transform() seems buggy

1

In the implementation of `get_affine_transform ()` https://github.com/Jeff-sjtu/HybrIK/blob/403d1ae6d74c114f3c03eb92eeb320184ea54e61/hybrik/utils/transforms.py#L1310 You used `src_w` for the `y` coordinate: https://github.com/Jeff-sjtu/HybrIK/blob/403d1ae6d74c114f3c03eb92eeb320184ea54e61/hybrik/utils/transforms.py#L1325-L1326 I think it should be `src_h` and `dst_h`. That would produce wrong affine transformation between...

Callback method name typo in ChainTransform.__setitem__()

2

https://github.com/vispy/vispy/blob/525504ab61744ef5a50fa06b38298a35f30126c7/vispy/visuals/transforms/chain.py#L212-L217 **L215** misspelled `_subtr_changed ` to `subtr_changed`. But everything seems work well. What would that affect?