Naman Goel

Results 403 comments of Naman Goel

@zaydek This may be of interest to you: https://gist.github.com/nmn/b98c21fbf3ee02c35319940b14030f62 > assuming last still wins It does. The main concern with this pattern is about detecting unused styles. JS tooling usually...

> What happens when multiple parent nodes use the same id ? If two anscestor have the same id, then if either one matches the given pseudo-class, then the style...

> is when composable? @zaydek It's not intended to be. > I say that because I've implemented anti patterns in the past without knowing, so having stricter errors up front...

@predaytor Sorry for the late reply. I was on a vacation. This work is currently on the back-burner as there isn't an obvious good API for this feature yet. We...

This is a valid issue. You can suppress the ESLint error for now.

@necolas My bad. I assumed it was a bug in the Babel plugin because it used to be a bug at one point. You're right, the best solution here is...

> should this be removed from the plugin? With some extra checks to disallow it for anything *but* pseudo elements.

How are `0%` and `0px` different in practice? Can you try using a non-zero value and see that it works as expected? We have a value minification process that tries...

Thanks for the example. While, this is a convincing argument for making a change, I did want to point something out. If you read about `flex-basis` on MDN, you'll see...

Needing `cjs` with Rollup was not something I would've expected. Will take a look at this soon.