stylex icon indicating copy to clipboard operation
stylex copied to clipboard

chore: Add cjs to rollup-plugin

Open VojGin opened this issue 1 year ago • 3 comments

What changed / motivation ?

I had came to a need of stylex rollup-plugin in the cjs flavor. See this issue for relevant context. https://github.com/facebook/stylex/issues/451

So I added it. My PR is very much inspired by the current implementation in packages/styles/package.json

Linked PR/Issues

Fixes https://github.com/facebook/stylex/issues/451

Additional Context

The rollup-plugin now generates lib/* and lib/es/* folders. See screenshot:

image

I had run all the tests and lints. But as I'm unfamiliar with the repository. I'd gladly ask for a double check that I didn't break anything vital. 🙏

What I have manually tested:

  • The output lib/es/index.mjs is identical with the old lib/index.js
  • The cjs flavor of the library was tested in my project and seems to be building correctly

Tagging @nmn as a follow-up to our discussion

Pre-flight checklist

VojGin avatar Apr 14 '24 16:04 VojGin

Hi @VojGin!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Apr 14 '24 16:04 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Apr 14 '24 20:04 facebook-github-bot

Needing cjs with Rollup was not something I would've expected. Will take a look at this soon.

nmn avatar Apr 15 '24 09:04 nmn

@VojGin This is exactly what we currently need on our project. @nmn What is blocking this merge request please?

Luko248 avatar May 20 '24 07:05 Luko248

I was away for a couple of weeks. Thanks for the PR! Will put out a release soon.

nmn avatar May 21 '24 02:05 nmn