Naman Goel

Results 403 comments of Naman Goel

@olivierpascal Expect it in the next couple of days after which I will work to create a new patch release with every fix as suggested.

This is a known issue. As of right now, you're responsible for ensuring that your media queries do not conflict. ```tsx const styles = stylex.create({ // ... x: { backgroundColor:...

Don't use `@media (min-width: 769px) and (max-width: 1024px)`. It won't account for hi-dpi displays and you'll get a 1px dead zone. If you really want to avoid the overlap, use...

> This is another PR that shouldn't be merged until we've migrated internal XPR/RN code onto the StyleX theme APIs I don't think is gonna be fully done for months...

This is expected. We're working to update the docs to make this clear.

@necolas I still think that having these types exported from files gives us the most flexibility. We can override particular files for TS easily that way.

@necolas Our tooling can only split on a file level, so having those files for TS where they're just aliased to `{}` and `string` as @efoken suggested is the easiest...

Interesting idea. Happy to accept a PR since this is not urgent enough to prioritise in the short term.

It's not. Currently it's manually copied. Happy to have you work on automating this, although there are parts that are not easy to automate. Some parts are incompatible altogether. So...

I've been thinking about this for a while. Within theming APIs specifically, we could convert `light-dark()` into dark mode media queries automatically. It should also be possible to define a...