nlisker
nlisker
@kevinrushforth We need some help here. > Regarding this i am a little confused about the OCA: I suppose i should appear on the list of signatories, but i cant...
> Then how about just "constantAttenuation", etc.? Since the suffix "Factor" might be self-explanatory, so we could as well leave these out. That could work. I'll suggest an API (methods...
Here is my proposed API. It will be accompanied by an update to the class documentation. /** * The range of this {@code PointLight}. A pixel is affected by this...
I added `@since 13` in an edit probably as you were writing. Point 3 is interesting. I would say: * All these examples are for the `controls` module, and we...
@FalcoTheBold Do you have any update? @kevinrushforth Can we continue with the review?
Iv'e had this on my to-do list for the `Color` class. Looking at the Java class and the CSS: **Java** has * a general `deriveColor` method for HSBA. * `brighter`/`darker`...
I think `transparentize` and `opacify` make more sense, at least on the Java side. `brighter`/`darker` should probably have been `brighten`/`darken`.
> ignoring the method altogether might hide the issue where the method is supposed to be static but isn't. I agree. Maybe a warning should be emitted.
Did you test with the test code I linked to you that both implementations produce the same results?
> I took the file as it is from the sources you provided and the IDE seems to have no issues with the indents (i use spaces, no tabs) or...