nlisker

Results 233 comments of nlisker

> I'm fine with doing a fix, but I need to know which one. Avoiding NPE's and silently doing nothing is IMHO not very desirable as this will give the...

The fix for the bug with nested events releasing the lock seems fine. I'm still not sure if the behavioral change is what we want the result to be even...

> I don't think we should care about depth-first, breadth-first. The only thing that I think is important here is that the contract of ChangeListener is respected. I think that...

> I couldn't quite see which you prefer here; you said "This one makes sense" but not quite sure which version it refers to (I suppose the depth first version?)...

> Confusing me again here :-) Did you mean to say "breadth-first" where you said "depth-first" ? > > Breadth first is for sure a lot easier, as the old...

I tried this test: ```java static void withRemovalAnd2Changes() { inv = 0; var property = new SimpleIntegerProperty(0); ChangeListener

With this test ```java static void with2Changes() { inv = 0; var property = new SimpleIntegerProperty(0); ChangeListener

@jperedadnr It seems that there's a need to update the examples and the dependency versions. For example, the Gradle version is 5.0 (https://github.com/openjfx/samples/blob/master/IDE/Eclipse/Modular/Gradle/hellofx/gradle/wrapper/gradle-wrapper.properties). Some of them don't work for me,...

I can review the Eclipse and maybe some of the command line ones.