openjdk-jfx
openjdk-jfx copied to clipboard
javafxports
WIP: JDK-8217477: Implement attenuation-coefficients for PointLight
Adding attenuation factors to the ES2-pipeline of the JavaFX 3D-API
I'm not sure if this is super WIP or not but it's pretty non-standard to add comments to all the changes with your handle "FalcoTheBold" as that's what git/hg history is for. Not a big deal just pointing it out this superficial (non-code related) detail.
@brcolow They can indeed be considered super WIP, these comments are just reminders from the time when i worked on the code apart from my usual work station and are supposed to be removed/replaced later of course.
Did you test with the test code I linked to you that both implementations produce the same results?
Moreover, there are many spacing changes, such as in D3DContext.java and I'm not sure at all these are within the style conventions of OpenJFX. Kevin would have to comment on this I think.
I think these should be reverted. This sort of wholesale reformatting is discouraged because it makes changes harder to review (and can sometimes cause merge conflicts).
@nlisker
Did you test with the test code I linked to you that both implementations produce the same results?
Not yet, but i plan to do just that shortly. I admit i worked a little hastly in order to finish this issue before the next incoming flood of customer support will steal the remaining time from me.
Regarding
Moreover, there are many spacing changes, such as in D3DContext.java and I'm not sure at all these are within the style conventions of OpenJFX. Kevin would have to comment on this I think.
I took the file as it is from the sources you provided and the IDE seems to have no issues with the indents (i use spaces, no tabs) or the likes. My own additions indeed need some reworking, albeit there are indent issues at places in the sources i didn't touched. Surely this is not a common thing with the sources in OpenJFX? (not saying i wouldn't fix them though)
I took the file as it is from the sources you provided and the IDE seems to have no issues with the indents (i use spaces, no tabs) or the likes. My own additions indeed need some reworking, albeit there are indent issues at places in the sources i didn't touched. Surely this is not a common thing with the sources in OpenJFX? (not saying i wouldn't fix them though)
The sources I uploaded do not change indentation. I'm not sure what indentation issues you are referring to.
The sources I uploaded do not change indentation. I'm not sure what indentation issues you are referring to.
May i know which IDE you used for working on your sources? I think i will switch temporarily the tools i use for editing since something is not working straight at the moment.
You see a Github-rookie at its finest, sorry for the inconveniences. I plan to squash the commits soon, but since @nlisker is now listed as reviewer, how should i go on about the squashing?
The implementation looks promising. Can you test with the app I uploaded that we get the same visuals?
@FalcoTheBold How's it going? We are slowly running out of time to get all the planned changes into 13. We need to leave enough time for reviewers too.
@FalcoTheBold How's it going? We are slowly running out of time to get all the planned changes into 13. We need to leave enough time for reviewers too.
Hello there. At the moment i am in quite a pinch with my regular work, finding little time to work on this and my other projects. Nonetheless i am on it to test it on the Linux-systems, just lately i had a sprint with my colleague on another work, thus taking less time on the issues here. This will change in a short while however, i will update you then.
As announced in this message, the official jfx repository is moving from hg.openjdk.java.net/openjfx/jfx-dev/rt to github.com/openjdk/jfx.
This sandbox repository is being retired on 1-Oct-2019. You will need to migrate your WIP pull request to the openjdk/jfx repo if you want to continue working on it. Here are instructions for migrating your pull request. The updated CONTRIBUTING.md doc has additional information on how to proceed.
Once you have done this, it would be helpful to add a comment with a pointer to the new PR.
NOTE: since this is a feature / enhancement request it needs to be discussed on the openjfx-dev mailing list if you want it to be considered.
The new openjdk/jfx repo will be open for pull requests on Wednesday, 2-Oct-2019. I will send email to the openjfx-dev mailing list announcing this.