Nir Soffer

`--` is typically used to separate the command arguments from sub command arguments. For example `kubectl exec pod -- command to exec inside the pod`. This is not really needed...

Add a question here: https://github.com/esnet/iperf/discussions/1802

@avoidik you seem to rebase on other unrelated commits. Please rebase on master so you have only the commit fixing the Makefile.

Documentation is missing. It is better to start with documentation, *before* implementing. This helps to discuss the big picture, evaluate the user experience, and is much quicker to iterate on.

I think it will be more useful to provide a C API to the rust code so it can be used as a library instead of maintaining duplicate implementations.

Did we try with upstream tcpproxy? the givisor version is not the same. Upstream version does: 1. Start io.Copy(src, dst) 2. Start io.Copy(dst, src) 3. When io.Copy() finish, do CloseWrite(dst)...

Not sure that this should be configurable, but you change the timeout and check if bigger value works with your system. To get more data on this, adding a debug...

> > Not sure that this should be configurable, but you change the timeout and check if bigger value works with your system. > > We're running this on GitHub...

> Ah btw: the github runner have the hardware acceleration: https://github.blog/changelog/2023-02-23-hardware-accelerated-android-virtualization-on-actions-windows-and-linux-larger-hosted-runners/ Yes it seems they added it recently, I saw that other projects started to use this. In the failing...

@afbjorklund can you review this? I think the issue of not having /dev/dri is using too old kernel. We are using 5.10.207 while libkrun seems to require 5.16 or later....