Nir Soffer

> will it work as official kubectl plugin also ? What is "official" plugin? do you mean when installed via krew? I'm using this for kubectl-gather installed manually from github...

I think we need to change the way the clusters are validated. This is relevant only to running some commands so it should not be done in a pre-run function.

> > Also the Network page for a VM could have a simple description of each mode, or a link to the section in the docs for each type. The...

Lint errors are fixed in #2181, go 1.23 tests added in #2182. I rebased on both temporarily to verify all tests and go version with this change.

@marckhouzam can be merged now

@marckhouzam can you check gain?

> Would it be a good idea to refactor all `fmt.Errorf("unknown command xx %s", ...)` with `fmt.Errorf("%w xx %s", ErrUnknownCommand, ....)` such that the main function could check with `if...

Looking in qemu code integrating with vmnet, it uses: ``` static NetClientInfo net_vmnet_shared_info = { .type = NET_CLIENT_DRIVER_VMNET_SHARED, .size = sizeof(VmnetState), .receive = vmnet_receive_common, .cleanup = vmnet_cleanup_common, }; ``` So...

Handling qemu dgram (-net dgram,) looks similar: ``` static NetClientInfo net_dgram_socket_info = { .type = NET_CLIENT_DRIVER_DGRAM, .size = sizeof(NetDgramState), .receive = net_dgram_receive, .cleanup = net_dgram_cleanup, }; ``` So with -net...

I did quick performance testing with and without TSO and checksum offload. It shows that in most case disabling offloading improves performance significantly and give more consistent results. However in...