Nir Soffer

JSON objects keys must be only strings,this should raise ValueError or TypeError: ``` json.dumps({1: "x"}) ``` This behavior smells like php to me :-)

I think we can rename TRAVIS_CI to GITHUB_CI. All the OVIRT_CI checks are not relevant and likely can be removed. Some of the TRAVIS_CI marks are also not relevant and...

It makes sense, but we need to check if engine is using the incorrect error code in this flow. Changing the error code in vdsm may break engine. If engine...

@mz-pdm anything to add?

Not enough detail here to do anything, but the discussion in the users mailing list https://lists.ovirt.org/archives/list/[email protected]/thread/XZIF7CRTSE2BAECCZ72M2EH7F4I5FYQ7/ reveals that this is an issue with oVirt node. When you upgrade it you...

We don't use prealloaction=metadata and preallocation=full, but we may want to use them in the future. Currently when creating preallocated disk on file storage with incremental backup enabled, we create...

Changing VGs can be done only the SPM host. Other hosts should not check or warn about the VG since they cannot fix this issue. We need to add a...

It makes sense to use configure values, but the localdisk is a bad hack that should be removed, and I think it does not work with python 3.

@tinez looks like your area - Harel just posted a patch to this module, so maybe he want to clean this up.

@bennyz what do you think?