Nir Soffer
Nir Soffer
Converting once at the end of the download is better, but with improve go-qcow2reader this save only 2 seconds for the default image, so it is lower priority. I'll open...
Great question! For verifying checksums we can use blksum: https://gitlab.com/nirs/blkhash It requires libnbd and qemu-nbd for reading qcow2 images (or any other format), but if you have your own qcow2...
Updating results, we now only 12-13% difference. Tested with: - OpenSSL 3.2.1 30 Jan 2024 (Library: OpenSSL 3.2.1 30 Jan 2024) - b3sum 1.5.0 (from brew) - 3 versions from...
I also started to work on adding meson build system, but it requires more work: https://github.com/nirs/BLAKE3/tree/meson Reusing the existing cmake build is more practical.
> Is there no way to tell Meson to look in the `c/` subdirectory? Unfortunately no, it requires build files at the root. > I've been thinking about cleaning up...
I don't need this now since blake3 is packaged for a while for fedora.
@dupondje If this info is passed to vdsm in the event, vdsm can log it. You can check how vdsm handles the event and if we have more info in...
@josgutie ok lets continue here, but please do not close PRs and submit new one like this. If there was an issue with the previous PR it can be easily...
> @nirs suggested testing a new deployment, it will take some time, but I guess that I could check the scenario. Test looks good, and sure we want to test...
Also, do we have tests for code modified in this PR? if not we should not change it before adding tests. The new rsync flow should also have tests.