Nils

Results 135 issues of Nils

ref https://github.com/valhalla/valhalla/issues/3685#issuecomment-1199818890 simplifies to only one Dockerfile and removes the `docker` directory. Dockerfile-build was merged with Dockerfile-run and circleci jobs install their own deps now.

ref. https://github.com/valhalla/valhalla/issues/3371#issuecomment-1205090389 apparently in some situations duplicate waypoints trigger an already solved bug: #3371 . the following request shows it: ``` curl --request POST \ --url https://valhalla1.openstreetmap.de/trace_attributes \ --header 'Content-Type:...

just wanted to try it in another project, but seems I can spare the effort: https://github.com/mapbox/mason I'll just leave that here. we're hardly using it, probably we can switch to...

recently ran a US tomtom dataset where we were handling ferries pretty naively and valhalla attempted to build a 24 000 km shortcut :joy: ``` 2021/12/20 21:33:30.842885 [INFO] Done HierarchyBuilder...

enhancement
good first issue

had a client who couldn't route over a shorter ferry and was always sent over the longer ferry: https://valhalla.openstreetmap.de/directions?profile=car&wps=-5.011911392211915%2C54.96160781245034%2C-5.79681694507599%2C54.848578936001466 ![image](https://user-images.githubusercontent.com/25637358/166741050-f653234d-1eaa-4cbe-9d78-c6cee6960ee1.png) when we moved the destination onto the ferry ramp, it...

before I go ahead with it: what you think about adding a proper pre-commit script to valhalla? mostly to try and prevent all these format.sh commits.. it can also be...

tools

was just looking at admin building and realized that geos seems to only be used in https://github.com/valhalla/valhalla/blob/master/src/mjolnir/adminbuilder.cc. quickly skimming the code I don't think I saw stuff that's not possible...

enhancement
good first issue

Would be nice to tell a user when certain things happen while processing, e.g. clamping values to their allowed maximum, enabling `destination_only` roads in 2. pass, deprecating request parameters etc....

enhancement

I'm unsure if we're handling numeric defaults for exclusive attributes like `weight`/`height` etc really well. e.g. `truck` has really high defaults: https://github.com/valhalla/valhalla/blob/5939f8fd32b57ddfe57cd1379d57ae8db8e47c24/src/sif/truckcost.cc#L50-L54 it might sorta reflect the average truck, but...

question
sif

While working on #2111, I found that there's a bug when providing more than 1 origin location for isochrones: it simply overwrites the isochrone result for each location with the...