Nils

Results 135 issues of Nils

I recently read a great tutorial on CMake for packaging: https://alexreinking.com/blog/building-a-dual-shared-and-static-library-with-cmake.html. Lots of good pointers on how to modernize a CMake setup. I'd like to take a stab at that...

cleanup

Seems to be a drop-in replacement by the same dev: https://github.com/martinus/unordered_dense. There's a cpp file but that seems to be providing some C++20 specific modularization stuff, so not needed yet....

enhancement

ref https://github.com/valhalla/valhalla/issues/3924#issuecomment-1398171301. The docs say `directions_type` should be nested in the `directions_options` object, but the code expects it top-level. I guess the docs were the intended behavior and we should...

fixes #4467 this is just a start, unfortunately these changes let all gurka tests fail currently with "no edges near location", very cryptic.. in any case, I wouldn't merge this...

supersedes #4340 @johannes-no, I had to open another PR to finish this, your fork wasn't editable. I just added the review comments so we can merge this. I'd soon like...

original in https://github.com/valhalla/valhalla/discussions/4113 It has a higher chance when it's in issues IMO. Originally posted by **farfromrefug** May 17, 2023 Could be useful to be able to do the same...

enhancement

We talked about it before: `no_thru` & `destination_only` are really the same thing, especially after https://github.com/valhalla/valhalla/pull/3812. We can't (sanely) re-purpose the bit in the tiles I think, but we could...

v4

Here we convert to short ton for a few countries: https://github.com/valhalla/valhalla/blob/d25c8eeed544e5bea47de94394980b3c26e579dd/src/mjolnir/graphenhancer.cc#L1681-L1687 In _theory_ mappers should use `maxweight = 10 st`, but probably that's not used consistently. I guess it's fine...

question

we talked about it and came to the conclusion that there's no point to have timezones & admins optional. there's tons of issues with no admins added, and also having...

cleanup

~~I was made aware of another issue with ferries going from Denmark to Sweden (with `motor_vehicle=yes`): https://www.openstreetmap.org/way/693547643.~~ ~~Even car doesn't take the ferry when routing from station to station: https://valhalla.openstreetmap.de/directions?profile=car&wps=10.537530183792114%2C57.4341890049026%2C11.94488525390625%2C57.71441474440813~~...

bug