Nils

One of the ideas initially with the `index.bin` in the tar file was not only to blazingly fast build our mmap access, but it could also be used to fetch...

`IsClosed` evaluating the wrong direction on reverse search

1

E.g. in https://github.com/valhalla/valhalla/blob/d7b0dccdc33ac3a7cf214a88c1f43af9d0790e4a/src/thor/bidirectional_astar.cc#L337-L343 On reverse search it seems we evaluate the closed state of the _expanded_ edge, not its opposing, which is what we're really interested in. That's the same...

optimize exclude_polygons computation

7

Leaving it here for future work: Instead of collecting all edges within each polygon and adding them to the user-avoided edges, we could collect only the edges _crossing_ a polygon...

collecting missing documentation of request options

1

This is a collection issue for missing documentation on request parameters. Anyone can add to this when they encounter smth that's not in the API docs. - [ ] `prioritize_bidirectional`:...

Penalize side of street change

5

I had a request to penalize when origin/destination are on different sides of the street, which is obviously only relevant for singly digitized roads which are not oneways. This can...

We talked about it offline. While we're not exactly agreeing on the optimality of the approach (also no one tried to write a proof), I'd like to see the expansion...

Street name filter

1

Didn't really think about it yet tbh, just leaving it here for now, so I'll remember to think about it (and possibly see what others think). A filter based on...

It's not very abundant, but for HGV again, it's important to be as good as we can respecting restrictions. `maxweight`/`maxheight` etc all have forward/backward tags. Obviously on commercial datasets much...

I just realized that https://github.com/valhalla/valhalla/pull/4279 introduced code that crazily logs on a planet build. Here the problematic part: https://github.com/valhalla/valhalla/blob/0e5770eb93bfc47376a2369f99152f747532a3f2/src/mjolnir/elevationbuilder.cc#L58-L63 Basically it prints each elevation postmark _if_ there's an error. I...

ARM & OSX test build failing the tar_index test

6

https://app.circleci.com/pipelines/github/valhalla/valhalla/11448/workflows/0c56e848-36e5-440b-b153-f7933d1d459f/jobs/60292 I think I remember that one failing on M1.