Nils Ohlmeier
Nils Ohlmeier
Thanks a lot for the help so far @peterdettman ! Based on your advice above I created the following PR https://github.com/jitsi/jitsi-media-transform/pull/413 to only pass the SignatureAndHashAlgorithm if supported by the...
Thank you @peterdettman! I didn't consider the negotiation as part of the state information. Makes total sense in hindsight. I don't think it is a big deal, as for these...
@na-g do you consider this to be a blocker for a 0.2 release? I think I would rather ship a 0.2 now and add this maybe to a dot release...
I'm okay with the parser accepting all assigned values, minus what @na-g said making sure Firefox does something sane. But I'm not sure why the parser should accept the unassinged...
I think exposing these setters as public should be easy enough. I'm guessing we didn't run into this issue so far as our current implementation actually does pass around strings...
@jrmuizel thanks for the pointer. We briefly looked at other binding generators, but failed to find a suitable one. cbindgen looks interesting
Well we do have a test verifying that it returns an error https://github.com/mozilla/webrtc-sdp/blob/master/src/lib.rs#L1297 What would be arguments to make this a success instead?
Yes that probably makes sense to improve.
This should fix the clippy warnings encountered in #262 CI run.
Looks like Travis has trouble with macOS machines.... :-(