Nils Ohlmeier

API contract for init() expects re-initing

3

It surprised me to learn the internal self test calls init() several times and appears to expect that the underlying crypto library get re-initialized with the new key. From other...

DTLS 1.0 backward compatibility broken since 1.69

4

In the Jitsi project (https://github.com/jitsi/) we just tried to upgrade our BC version from 1.68 to 1.70 and ran into the following issue: We have one endpoint which uses BC...

Highlighted here https://github.com/mozilla/webrtc-sdp/issues/226#issue-671193632 using check_parse_and_serialize() in unit_tests.rs can reveal new errors. But simply turning it on results in new problems like \r\n at the end of the SDP missing.

Firefox C parser support for a=group - fec-fr - cs - dup Do we need to add support for these to this rust parser as well? See https://searchfox.org/mozilla-central/rev/ec806131cb7bcd1c26c254d25cd5ab8a61b2aeb6/media/webrtc/signaling/src/sdp/SdpAttribute.h#475

It would be helpful to have references to each RFC where every attribute is defined in.

Currently the automatically generated documentation on https://docs.rs/webrtc-sdp/0.1.0/webrtc_sdp/ looks pretty sad. We should look into adding the documentation in the code so it can get picked up by docs.rs

Replace split_whitespace().collect() calls

2

Instead of using split_whitespace().collect() to get a temporary vector just use split_whitespace() and then the iterator with .next() for parsing.