webrtc-sdp icon indicating copy to clipboard operation
webrtc-sdp copied to clipboard

Should parsing an empty document yield specific error?

Open na-g opened this issue 6 years ago • 3 comments

@nils-ohlmeier, what should happen when an empty document is parsed?

na-g avatar Nov 08 '19 20:11 na-g

Well we do have a test verifying that it returns an error https://github.com/mozilla/webrtc-sdp/blob/master/src/lib.rs#L1297

What would be arguments to make this a success instead?

nils-ohlmeier avatar Nov 08 '19 21:11 nils-ohlmeier

I have updated the question to ask if we want to yield a specific error (which would be matchable) if the document is empty.

na-g avatar Nov 08 '19 21:11 na-g

Yes that probably makes sense to improve.

nils-ohlmeier avatar Nov 08 '19 21:11 nils-ohlmeier