Niklas Wenzel

Results 243 comments of Niklas Wenzel

We should be VERY careful making any changes here. Breaking the auto updater is fatal.

Please link to the issues the PR is supposed to fix in the PR description.

Closing because no feedback was provided which issue this is supposed to fix.

If you could attach a video of the fade-in you're seeing, that would be helpful, too!

This setup has always worked for me: https://www.electronforge.io/config/makers/squirrel.windows#spaces-in-the-app-name

> ### Forge version > > 7.6.0 Afaik MSIX support was only added in v7.10. Can you try upgrading? CC @bitdisaster

Was just about to open a similar PR, then found this. I think it also makes sense to adjust this section to explain what the default behavior is: https://github.com/electron/electron/blob/93f49d118956932ef051eeefe6b377239b10d75c/docs/api/structures/web-preferences.md?plain=1#L20-L24

@LeUser111 Sorry, now I was busy. :) I think it's still worth mentioning the default value as it saves people from having to read a different page just to learn...

Try this: ``` git checkout docs-security-default git reset --hard c79d079ad384de4169094836b98b202ce1378498 ``` This should reset your branch to the state from before you last force-pushed. You can find the commit hash...

This indicates signing failed. Usually, this happens if the `windowsSign` configuration is incorrect. Unfortunately, it doesn't currently print the exact error message from `signtool.exe` to the console. You could check...