Niklas Wenzel comments

Results 243 comments of


                                            Niklas Wenzel

feat: add `copyVideoFrameAt` and `saveVideoFrameAs` methods on `webContents`

> It looks like this pull request touches one of our dependency or CI files, and per [our contribution policy](https://github.com/electron/electron/blob/main/CONTRIBUTING.md#dependencies-upgrades-policy) we do not accept these types of changes in PRs....

feat: add `copyVideoFrameAt` and `saveVideoFrameAs` methods on `webContents`

@velentZ Sorry that it's taking a while! If you need it immediately, you can always [compile Electron with the patch from source](https://www.electronjs.org/docs/latest/development/build-instructions-gn). @dodolalorc It looks like the merge commits triggered...

feat: add `copyVideoFrameAt` and `saveVideoFrameAs` methods on `webContents`

@dodolalorc Agree that that's what was going on. (I later updated my comment above, but it probably didn't send you a notification for that.) I've pinged our admins to see...

feat: add `copyVideoFrameAt` and `saveVideoFrameAs` methods on `webContents`

We're seeing crashes in CI: ``` [1716:0928/183528.604:ERROR:third_party\blink\renderer\core\html\media\html_media_element.cc:5045] SetError: {code=4, message="MEDIA_ELEMENT_ERROR: Format error"} [9080:0928/183528.604:FATAL:base\task\sequence_manager\thread_controller.cc:653] DCHECK failed: !delta.is_negative(). -0.000605 s Symbols not available. Dumping unresolved backtrace: 0x7ff6985ffeb5 0x7ff6986101dc 0x7ff69872a254 0x7ff69872a119 0x7ff69874a73a 0x7ff69874a06c...

Setting setAlwaysOnTop(false) when the Electron window loses focus does not take effect immediately; it requires clicking multiple times or dragging the title bar of another application's window before that window can overlay on top of the Electron window.

Thanks for filing this issue and including a video! Could you please remove `nodeIntegration: true` from the testcase gist? Using it in combination with third-party websites is a security issue...

Setting setAlwaysOnTop(false) when the Electron window loses focus does not take effect immediately; it requires clicking multiple times or dragging the title bar of another application's window before that window can overlay on top of the Electron window.

Thanks for adjusting the gist! Just to make sure, does `setAlwaysOnTop(false)` work properly for you while the window has focus? For context, this seems to be a Windows-only issue. It...

Setting setAlwaysOnTop(false) when the Electron window loses focus does not take effect immediately; it requires clicking multiple times or dragging the title bar of another application's window before that window can overlay on top of the Electron window.

Can you just quickly modify your testcase gist to call `setAlwaysOnTop(false)` in a `setTimeout(/* call here */, 2000)` after the app is started to see if it works properly when...

Setting setAlwaysOnTop(false) when the Electron window loses focus does not take effect immediately; it requires clicking multiple times or dragging the title bar of another application's window before that window can overlay on top of the Electron window.

Thanks for testing!

feat: allow SF Symbols to be customised

Thank you so much for creating this PR! Genuinely appreciate it. The goal would be to achieve the native look and feel of macOS Tahoe context menu icons as closely...

feat: allow SF Symbols to be customised

Thank you so much for your reply! 1. Ah, didn't realize template image would do that. That's great. 2. After looking into it more, I think macOS might already create...