Niklas Wenzel comments

Results 243 comments of


                                            Niklas Wenzel

feat: allow SF Symbols to be customised

> I'm not sure how to replicate this functionality as I'm not familiar with that part of the codebase, so right now `createMenuSymbol` can create inconsistent menus. Here's what I'd...

`BaseWindow.maximize()` won't automatically show the window on Linux if created with `show: false`

Thanks for reporting this issue! Just to make sure we're all talking about exactly the same code, would you be able to upload your test code as a testcase gist...

`BaseWindow.maximize()` won't automatically show the window on Linux if created with `show: false`

Thank you!

`BaseWindow.maximize()` won't automatically show the window on Linux if created with `show: false`

> Maye you want to check if this is fixed for you with 35.1.4? @staniel359 Could you let us know, please? (Thanks, @mkurz!)

`BaseWindow.maximize()` won't automatically show the window on Linux if created with `show: false`

Thanks for testing. Could you please update your Fiddle gist with the Electron version that you used? (Just hit "Publish" in Fiddle again.)

`BaseWindow.maximize()` won't automatically show the window on Linux if created with `show: false`

@staniel359 If there is no comment on the issue, then there hasn't been any progress.

window maximize graphical bug electron39 arm64

Thanks for reporting! Just to confirm, are you using Wayland? CC @mitchchn

Wrong cookie change cause and wrong delete flag in Cookie listener.

Thanks for reporting! Sorry, I missed that you have a PR up already. In that case, we can skip the repro. I assume it refers to https://www.electronjs.org/docs/latest/api/cookies#event-changed.

docs: add generics for `ContextBridge` APIs

Thanks for taking a look at our issue backlog! Unfortunately, sometimes people suggest things that don't make sense. I'd vote for closing the PR (and the linked issue) but will...

docs: clearer wording (performance common pitfalls)

@soobinrho Are you still interested in getting this PR merged? If yes, could you please rebase on `main` and implement @erickzhao's [suggestion](https://github.com/electron/electron/pull/45308#issuecomment-3535090813)? Thank you!