Niklas Wenzel
Niklas Wenzel
[Kanishk's patch](https://chromium-review.googlesource.com/c/chromium/src/+/7239386) has made it into Chromium! :tada: Unfortunately, the reviewers [insisted](https://chromium-review.googlesource.com/c/chromium/src/+/7239386/comment/284cc0dc_fb06554b/) on reducing the icon size to 32x32 pixels. This is because Chromium only ever shows the icon as...
The more I think about it and especially after rereading our [patch policy](https://github.com/electron/electron/blob/main/docs/development/patches.md#patch-justification), I believe the following is the best path forward: Introducing a function like this: ```cpp gfx::ImageSkia DoGetWindowIcon(content::DesktopMediaID...
@fanhillary I don't have an ETA. Most maintainers are [off for the holidays](https://www.electronjs.org/blog/dec-quiet-period-25). However, @KanishkRanjan has a [PR](https://github.com/electron/electron/pull/49219) up that will solve the issue. A realistic timeline to have it...
I'd suggest fixing the underlying bug instead of documenting the behavior.
> Can I work on it ? Yes, everyone is free to work on any issue in the Electron project. (No need to be assigned to it.)
Just played around with it. It's nice to get rid of the JavaScript `WebContentsView` resize listener: https://gist.github.com/nikwen/3cf40e8825776306dd69212b5ceffd5c
Not sure what an AP is.
Ah, thanks for explaining! I'm not super familiar with this part of the code. I'll let someone else review it.
It looks like some commits are still not signed. Would you be able to sign them? :)
All good! Signed properly now. You can go [here](https://github.com/electron/electron/pull/48149/commits) and you'll see "verified" next to every commit that has been signed.