llvm-project icon indicating copy to clipboard operation
llvm-project copied to clipboard

How to send pull request notices to a mailing list?

Open pogo59 opened this issue 2 years ago • 2 comments

Phabricator allows subscribing llvm-commits, cfe-commits, etc., so that new reviews and comments on existing reviews go to the appropriate mailing list(s). How do we achieve the same effect for pull requests?

pogo59 avatar Jun 28 '23 13:06 pogo59

@llvm/issue-subscribers-infrastructure

llvmbot avatar Jun 28 '23 14:06 llvmbot

Pull requests have labels like issues, so notifications should work in same way.

EugeneZelenko avatar Jun 28 '23 14:06 EugeneZelenko

My impression was that the labels auto-subscribed the members of the associated list, which is impractical for lists the size of llvm-commits. Maybe I'm wrong about how that works.

Currently, when a new issue gets created, it also gets emailed to llvm-bugs regardless of labels or subscribers. That's more like what we want for PRs, except it should email every update not just when the PR is created.

pogo59 avatar Jun 28 '23 18:06 pogo59

There is a webhook we have that emails the commit lists every time there is a push event. It looks like we can set up something similar to email the commits lists on pull request events too.

The webhook for commit emails is a python script that parses the json payload data from the event, formats it and sends the email off. If someone wants to take a try at another python script for parsing and formatting pull request events, we can get that installed for the repo. It doesn't even need the email sending code, because we can copy that from the existing script.

tstellar avatar Jun 28 '23 19:06 tstellar

Here is the script I mentioned in my previous comment: https://github.com/llvm/llvm-admin/blob/main/AWS/Lambda/CommitEmailer/commit_emailer.py

tstellar avatar Jun 28 '23 21:06 tstellar

This has been implemented.

nikic avatar Oct 21 '23 18:10 nikic