Nils Goroll

Just trying to be helpful to those of us still on X11

pthread_cond_{timed,}wait shall not return an error code of [EINTR].

2

Nitpick noticed during review of #4030 https://pubs.opengroup.org/onlinepubs/009604599/functions/pthread_cond_timedwait.html Piling as a PR because of the freeze FYI this goes back to eecd409d13f145765de3aeee4984179e0ae008b5

Assert error in mgt_vcl_discard(): Condition((vp->warm)

1

With #4048 applied, the test case from https://github.com/nigoroll/libvmod-dynamic/issues/110 can easily trigger this assertion failure when a lookup thread takes longer than `cli_timeout` to finish (I first saw this by accident...

Add req.filters and bereq.filters

14

### Summary These changes add support for request body filters on the client and backend side. The motivation for this feature will hopefully be obvious: To be able to transform...

this is for consistency, to simplify parsing and to reduce the amount of data logged with VSL. Filed as a PR because it is a breaking change to the VSL...

### Expected Behavior Test passes ### Current Behavior Test fails ### Possible Solution _No response_ ### Steps to Reproduce (for bugs) _No response_ ### Context TODO: Revisit 2cae35978727b706a02b77fce0c82e2863649687. http://varnish-cache.org/vtest/attachment_2cae35978727b706a02b77fce0c82e2863649687_SunOS_i86pc_5.11_1.05_gcc4.7.3%3CBR%3E-m32%3CBR%3EIPv6%3CBR%3Euffix_uplex_e00029.txt ```...

Do we handle 304 responses correctly?

10

I'm wondering if there aren't some potential problems unrelated to this patch that we have uncovered. The fact that Varnish will enter 304 revalidation logic even though we never asked...

director reference counting races

4

### Expected Behavior Director reference counting should avoid use-after-frees ### Current Behavior I believe there are still open races with our director reference counting #### Simple director assignment VCL: `set...

suspect unbuffered VSL regression

3

### Expected Behavior good VSL ### Current Behavior garbled VSL: ``` $ tail -20 tests/permutations.log **** v1 vsl| 1024 Debug c vped_include: enter **** v1 vsl| 1024 Debug c vped_include:...

ESI onerror="abort" handling for OC_F_FAILED

1

noticed _en passant_ : We should probably also abort for this case https://github.com/varnishcache/varnish-cache/blob/903611966b88aa464d22a9867411f31790b505f9/bin/varnishd/cache/cache_esi_deliver.c#L900-L904